-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[identity] Use tsx for tests #28808
Merged
Merged
[identity] Use tsx for tests #28808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run js - identity - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
maorleger
commented
Mar 7, 2024
/azp run js - identity - tests |
maorleger
requested review from
KarishmaGhiya,
schaabs and
a team
as code owners
March 7, 2024 22:32
maorleger
requested review from
pvaneck,
billwert,
ahsonkhan,
chlowell and
mpodwysocki
March 7, 2024 22:32
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Describe the problem that is addressed by this PR
Follows #28801 to use tsx for running identity tests, which avoids requiring the mocha workarounds
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Using esm4mocha, but I think this is a good path forward to try
Checklists