Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[identity] Use tsx for tests #28808

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Mar 7, 2024

Packages impacted by this PR

@azure/identity

Describe the problem that is addressed by this PR

Follows #28801 to use tsx for running identity tests, which avoids requiring the mocha workarounds

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Using esm4mocha, but I think this is a good path forward to try

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@maorleger
Copy link
Member Author

/azp run js - identity - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger
Copy link
Member Author

/azp run js - identity - tests

@maorleger maorleger marked this pull request as ready for review March 7, 2024 22:32
@maorleger maorleger requested review from KarishmaGhiya, schaabs and a team as code owners March 7, 2024 22:32
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maorleger maorleger merged commit 34da487 into Azure:main Mar 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants