Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iothub release #25474

Merged
merged 4 commits into from
Apr 25, 2023
Merged

iothub release #25474

merged 4 commits into from
Apr 25, 2023

Conversation

kazrael2119
Copy link
Contributor

@ghost ghost added the Mgmt This issue is related to a management-plane library. label Apr 6, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-arm-iothub

@@ -1,7 +1,7 @@
{
"Entries": [
{
"RequestUri": "https://management.azure.com/subscriptions/azure_subscription_id/resourceGroups/myjstest/providers/Microsoft.Devices/IotHubs/myiothubxxxxyyyjjrr?api-version=2022-04-30-preview",
"RequestUri": "https://management.azure.com/subscriptions/azure_subscription_id/resourceGroups/myjstest/providers/Microsoft.Devices/IotHubs/myiothubxxxxyyyjjrr?api-version=2022-11-15-preview",
"RequestMethod": "PUT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the ci failure

@@ -79,2055 +79,25 @@
"capacity": 1
}
},
"StatusCode": 201,
"StatusCode": 400,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case failure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao enabled auto-merge (squash) April 25, 2023 03:19
@MaryGao MaryGao merged commit 9164690 into Azure:main Apr 25, 2023
@kazrael2119 kazrael2119 deleted the iothub-re branch April 25, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants