You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables dev-tool to host mocha transpilation instead of using esm and ts-node separately. This makes execution of test code the same as execution of sample code, and enables one of the goodies that we have in samples (importing from a package itself by name rather than by path) work in tests as well as samples. This is pretty nice because the paths entries in tsconfig.json can sometimes make the editor want to import things by package name instead of by path, and this can lead to weird runtime errors when it doesn't work in tests but does work in samples.
It also allows tests to re-use utility modules from samples, which can save some code duplication such as in Form Recognizer where model schemas are checked in twice, once for samples and once for tests.
Hi @witemple-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @witemple-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @witemple-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.
dev-toolIssues related to the Azure SDK for JS dev-toolno-recent-activityThere has been no recent activity on this issue.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
no-recent-activity
github-actions
bot
added
the
no-recent-activity
Work in Progress
This PR enables dev-tool to host mocha transpilation instead of using
esmandts-nodeseparately. This makes execution of test code the same as execution of sample code, and enables one of the goodies that we have in samples (importing from a package itself by name rather than by path) work in tests as well as samples. This is pretty nice because thepathsentries in tsconfig.json can sometimes make the editor want to import things by package name instead of by path, and this can lead to weird runtime errors when it doesn't work in tests but does work in samples.It also allows tests to re-use utility modules from samples, which can save some code duplication such as in Form Recognizer where model schemas are checked in twice, once for samples and once for tests.