Integrate Asset-Sync Features

[scbedd]

@HarshaNalluru @timovv Sorry for the delay here! I intended on having this ready for you by last Thursday but failures wait for no one :(

I have some of the node tests passing, but I'm seeing failures that make no sense to me. (all of the test-utils pass still)

It's claiming it can't find the file after restoring the recordings. I'm digging into those failures. Wondering if there is anything special about those test cases.

EDIT 11/1: Green for browser tests now (including on textanalytics). Just need to adjust for feedback.

Resolves Azure/azure-sdk-tools#4256

[HarshaNalluru]

Thanks, @scbedd, will take a look.

[scbedd]

PR Resolving the test-proxy issue breaking these tests.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[timovv]

Thanks for the hard work on this Scott! I had a couple of queries. Some of them are just style-related, but I'd like to get your thoughts on just using the working directory to calculate the path.

[scbedd]

❤️ your commits on this Harsha. Thanks for the rewrite 👍

[timovv]

Looks good! Thanks Harsha for the follow up.

I did have one broader follow-up question (but happy to merge as-is) -- now that we're enforcing that the assets.json must be at the package level, is there anything actually stopping us from calculating the assets path as ${relativeRecordingsPath()}/../assets.json? That would simplify a lot and would mean we wouldn't need to add the extra environment variable.

[scbedd]

Looks good! Thanks Harsha for the follow up.

I did have one broader follow-up question (but happy to merge as-is) -- now that we're enforcing that the assets.json must be at the package level, is there anything actually stopping us from calculating the assets path as ${relativeRecordingsPath()}/../assets.json? That would simplify a lot and would mean we wouldn't need to add the extra environment variable.

Will the .. remain unresolved? I'm pretty certain the test-proxy would handle it.

I don't mind any adjustments. At the end of the day @timovv if that's how you'd like it, throw a commit on here that changes the behavior. If everything checks out then 👍

[timovv]

Blocking so we don't forget to remove the Text Analytics changes before merging.

Unblocking