Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] Make TEST_MODE environment variable value case-insensitive #22118

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

timovv
Copy link
Member

@timovv timovv commented Jun 6, 2022

Packages impacted by this PR

  • @azure/test-recorder

Issues associated with this PR

Describe the problem that is addressed by this PR

The TEST_MODE environment variable was previously case sensitive, leading to confusing results when setting it to a value with any upper-case characters (e.g., TEST_MODE=Live would result in running tests in playback mode). This change makes TEST_MODE case-insensitive.

Are there test cases added in this PR? (If not, why?)

Yes

Checklists

  • Added a changelog (if necessary)

@timovv timovv marked this pull request as ready for review June 6, 2022 17:49
Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fast 🚀

@timovv timovv merged commit 1010e5f into Azure:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recorder] TEST_MODE - eliminate case sensitivity
2 participants