[Schema Registry Avro] Fix nightly test #21176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check for API changes are not detected in this pull request for |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 17, 2022
Adding exhaustive hostType values and cores to Microsoft.AzureArcData\sqlServerInstance resource (Azure#21176) * adding new values for hostType and new cores property * removing new property from 2022-03-01 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@schema-registry-avro
Issues associated with this PR
Fixes #21175
Describe the problem that is addressed by this PR
The test checks if there was a request sent to register a schema even if the serialization of the input value failed. This request should return a schema ID for the registered schema but the test was expecting the schema ID to be undefined.
Successful run with this PR: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1480429&view=results. Note that the failure in min/max testing is expected because of a recent breaking change in Event Hubs that was not released yet (will be released this week).
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists