Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getRequiredEnvVar function with assertEnvironmentVariable helper from new recorder #21009

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

JonathanCrd
Copy link
Member

@JonathanCrd JonathanCrd commented Mar 23, 2022

Packages impacted by this PR

@azure/monitor-query

Issues associated with this PR

Describe the problem that is addressed by this PR

This PR introduces a small change. The function getRequiredEnvVar() is no longer necessary since the new recorder provides a helper method assertEnvironmentVariable() that behaves in the same way.

Provide a list of related PRs (if any)

This change was originally proposed in #20178 (comment)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@JonathanCrd JonathanCrd self-assigned this Mar 23, 2022
@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Mar 23, 2022
@JonathanCrd JonathanCrd changed the title Removing helper method and update references Replace getRequiredEnvVar function with assertEnvironmentVariable helper from new recorder Mar 23, 2022
@JonathanCrd JonathanCrd marked this pull request as ready for review March 23, 2022 22:03
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JonathanCrd JonathanCrd merged commit 31c1a6d into Azure:main Mar 24, 2022
@JonathanCrd JonathanCrd deleted the Monitor-Query-nit branch June 17, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants