Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] allowLoggingAccountIdentifiers support #20516

Merged
merged 11 commits into from
Mar 18, 2022
Merged

[Identity] allowLoggingAccountIdentifiers support #20516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fab2c91
allowLoggingAccountIdentifiers implementation
sadasant Feb 24, 2022
23d8dbd
removed unnecessary console.log
sadasant Feb 24, 2022
b4a5844
CHANGELOG entry
sadasant Feb 24, 2022
64afb0d
comments and quicker return if access token isnt present
sadasant Feb 24, 2022
2b3baae
one more test with the ManagedIdentityCredential
sadasant Feb 24, 2022
0db7487
enough with the atob and bta game. Buffer time!
sadasant Feb 25, 2022
61840fa
Merge remote-tracking branch 'Azure/main' into identity/fix20502
sadasant Mar 11, 2022
b38967f
fixed tests
sadasant Mar 11, 2022
24de7c3
moving allowLoggingAccountIdentifiers to loggingOptions
sadasant Mar 11, 2022
032d51b
CHANGELOG update
sadasant Mar 12, 2022
8db1bab
using the environment variables directly in the tests
sadasant Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/identity/identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

### Features Added

- All of our credentials now support a new option on their constructor: `loggingOptions`, which allows configuring the logging options of the HTTP pipelines.
- Within the new `loggingOptions` we have also added `allowLoggingAccountIdentifiers`, a property that if set to true logs information specific to the authenticated account after each successful authentication, including: the Client ID, the Tenant ID, the Object ID of the authenticated user, and if possible the User Principal Name.

### Breaking Changes

### Bugs Fixed
Expand Down
111 changes: 111 additions & 0 deletions ...cretcredential/recording_authenticates_with_allowloggingaccountidentifiers_set_to_true.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

205 changes: 205 additions & 0 deletions ...etcredential/recording_authenticates_with_allowloggingaccountidentifiers_set_to_true.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading