Implemented a backoff mechanism for the AutoRefreshTokenCredential #19804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
12 tasks
AikoBB
reviewed
Jan 19, 2022
sdk/communication/communication-common/src/autoRefreshTokenCredential.ts
Show resolved
Hide resolved
AikoBB
approved these changes
Jan 19, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
/check-enforcer reset |
|
/azp run js - communication - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jan 28, 2022
…zure#19804) * initial backoff implementation * added test for backoff * improved the autorefresh documentation * better explained scenarios * clarify tokenRefresher's expected return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklists
Packages impacted by this PR:
Issues associated with this PR:
Describe the problem that is addressed by this PR:
If the token returned by
token_refreshercallback (implemented by Contoso) is soon to expire or expired, theAutoRefreshTokenCredentialwould keep looping constantly trying to fetch a new token.We implemented a backoff mechanism for the case the token is soon-to-expire and throw an exception if the user fails to provide a non-expired token via the
token_refresher.What are the possible designs available to address the problem
If there are more than one possible design, why was the one in this PR chosen?
Does this PR needs any fixes in the SDK Generator? (If so, create an Issue in the Autorest/typescript repository and link it here)
Are there test cases added in this PR?(If not, why?)
Provide a list of related PRs(if any)
Command used to generate this PR:(Applicable only to SDK release request PRs)