Stop the test proxy container explicitly when tests finish #19473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timovv
requested review from
deyaaeldeen,
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
ghost
added
the
timovv
added
the
test-utils-recorder
harsha-nalluru
approved these changes
Jan 4, 2022
| // Licensed under the MIT license. | ||
|
|
||
| import { leafCommand, makeCommandInfo } from "../../framework/command"; | ||
| import { config } from "dotenv"; |
There was a problem hiding this comment.
why do you need dotenv here?
There was a problem hiding this comment.
Oops, just copied this from start.ts I think. Shouldn't be necessary.
HarshaNalluru
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving the container a name and then stopping it using
docker container stoponce tests complete should fix #19363.