[Text Analytics] Fix rate limit reached issue #19249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
sadasant,
xirzec,
jeremymeng and
HarshaNalluru
deyaaeldeen
requested review from
bterlson,
ramya-rao-a and
witemple-msft
as code owners
ghost
added
|
API changes have been detected in API changes - export declare function throttlingRetryPolicy(): PipelinePolicy;
+ export declare function throttlingRetryPolicy(maxRetryCount?: number): PipelinePolicy; |
xirzec
reviewed
Dec 13, 2021
sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts
Outdated
Show resolved
Hide resolved
xirzec
reviewed
Dec 13, 2021
…Client.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
deyaaeldeen
commented
Dec 13, 2021
deyaaeldeen
commented
Dec 13, 2021
sdk/textanalytics/ai-text-analytics/test/public/utils/recordedClient.ts
Outdated
Show resolved
Hide resolved
|
API changes have been detected in |
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
|
Haven't reviewed this but I know @sadasant is working in this area as well - I just wanted to make him aware so his changes do not regress anything added here (or vice-versa) ❤️ |
jeremymeng
approved these changes
Dec 14, 2021
|
@sadasant I updated an identity test so that it conforms to the updated number of retries. Please let me know if there is any issues there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18941
Sometimes, we get rate limit reached error responses from the service that exceed the default number of retrys in the throttling retry policy.
For context, this particular API supports running multiple Text Analytics actions from one request, so the service does not like getting many successive requests for it. I also confirmed with their engineering team that the test suite is a bit too big.
To fix this, the test suite could be trimmed down but I am afraid that will affect the current coverage. Instead, I updated the retry policy for the test client to retry more.