Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Update keyvault-secrets test to match .NET #17799

Merged
merged 16 commits into from
Oct 4, 2021
Merged

[Perf] Update keyvault-secrets test to match .NET #17799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c5d61c4
Configure client options for test-proxy
mikeharder Sep 21, 2021
7a977fb
Enable insecure HTTPS test-proxy
mikeharder Sep 21, 2021
0121abf
Record and playback all test instances
mikeharder Sep 22, 2021
4f867e4
Make one call to runAsync() before starting recording, to avoid recor…
mikeharder Sep 22, 2021
b404cf2
Verify vault is empty, purge and delete in cleanup
mikeharder Sep 22, 2021
d2f4855
Add reference to core-http
mikeharder Sep 22, 2021
7d9bbaf
Refactor delete and purge
mikeharder Sep 23, 2021
9ad6be2
perf-keyvault-secrets should depend on source version of keyvault-sec…
mikeharder Sep 23, 2021
8f42f55
Remove core-http dep
mikeharder Sep 23, 2021
aa862b6
Revert "Configure client options for test-proxy"
mikeharder Sep 27, 2021
10f9cfd
Revert "Record and playback all test instances"
mikeharder Sep 27, 2021
4e1a6d9
Revert "Enable insecure HTTPS test-proxy"
mikeharder Sep 30, 2021
20ad197
Merge branch 'main' into perf-keyvault
mikeharder Sep 30, 2021
7834b43
Merge branch 'main' into perf-keyvault
mikeharder Oct 1, 2021
9864037
Revert changes to perf framework
mikeharder Oct 1, 2021
12faa36
rushx format
mikeharder Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable insecure HTTPS test-proxy
  • Loading branch information
@mikeharder
mikeharder committed Sep 21, 2021
commit 7a977fb2c017f81db9a8056c91cc6227521d9c7e
1 change: 1 addition & 0 deletions sdk/keyvault/perf-tests/keyvault-secrets/test/secretTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export abstract class SecretTest<TOptions = Record<string, unknown>> extends Per

constructor() {
super();
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
this.secretClient = new SecretClient(keyVaultUri, credential, this.configureClientOptionsCoreV1({}));
}

Expand Down
5 changes: 3 additions & 2 deletions sdk/test-utils/perfstress/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.
import { IncomingMessage, RequestOptions, request } from "http";
import { IncomingMessage } from "http";
import { RequestOptions, request } from "https";
import { TestProxyHttpClient, TestProxyHttpClientV1 } from "./testProxyHttpClient";

/**
Expand All @@ -25,7 +26,7 @@ export function getEnvVar(name: string) {
*/
export async function drainStream(stream: NodeJS.ReadableStream) {
return new Promise((resolve, reject) => {
stream.on("data", () => {});
stream.on("data", () => { });
stream.on("end", resolve);
stream.on("error", reject);
});
Expand Down