Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Identity samples #16698

Merged
merged 74 commits into from
Aug 10, 2021
Merged

add Identity samples #16698

merged 74 commits into from
Aug 10, 2021

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Aug 2, 2021 •
edited
Loading

Added samples for :

  • Controlling User Interaction
  • Persisting the token cache
  • Persisting the AuthenticationRecord
  • Silent authentication with AuthenticationRecord and TokenCachePersistenceOptions
  • Name Token Cache
  • Allow Unencrypted Storage
  • Default Token Cache
  • Using National Clouds

@ghost ghost added the Azure.Identity label Aug 2, 2021
@KarishmaGhiya KarishmaGhiya linked an issue Aug 2, 2021 that may be closed by this pull request
[Identity] Align with samples in other languages #14435
Closed
@KarishmaGhiya KarishmaGhiya marked this pull request as ready for review August 2, 2021 21:10
KarishmaGhiya and others added 16 commits August 10, 2021 00:45
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
22b9493 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
4249588 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
b58e15e 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
66d9414 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
97e15da 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
1005630 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
a62a9bc 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
854dae1 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
0c1bf6e 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
b4616af 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
1b26916 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
41534ce 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
347326b 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
3248861 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
92cb2d9 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
65a4916 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
sadasant
sadasant approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what I see 😊

scottaddie
scottaddie approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good after incorporating the suggestions below.

sdk/identity/identity/samples/AzureIdentityExamples.md Outdated Show resolved Hide resolved
sdk/identity/identity/samples/AzureIdentityExamples.md Outdated Show resolved Hide resolved
KarishmaGhiya and others added 2 commits August 10, 2021 11:13
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
a27b49e 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya @scottaddie
Update sdk/identity/identity/samples/AzureIdentityExamples.md
05d79fa 
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
@KarishmaGhiya KarishmaGhiya enabled auto-merge (squash) August 10, 2021 18:24
@KarishmaGhiya KarishmaGhiya merged commit 3eb872b into Azure:main Aug 10, 2021
ckairen pushed a commit to ckairen/azure-sdk-for-js that referenced this pull request Aug 24, 2021
@KarishmaGhiya @ckairen
add Identity samples (Azure#16698)
03b102d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witemple-msft witemple-msft witemple-msft left review comments

@sadasant sadasant sadasant approved these changes

@scottaddie scottaddie scottaddie approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Identity] Align with samples in other languages
4 participants
@KarishmaGhiya @sadasant @scottaddie @witemple-msft