Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Text Analytics] Merge feature branch for v5.1.0 to main #16121

Merged
12 commits merged into from
Jun 30, 2021

Conversation

deyaaeldeen
Copy link
Member

It consists of the following already-reviewed PRs:
#16114
#16095
#15995
#15684
#15649
#15598
#15554

* [Text Analytics] Regenerate with service v3.1 swagger

* export TextAnalyticsAction

* move modelVersion to TextAnalyticsAction

* export HealthcareEntityCategory

* edit comment

* edit
* [Text Analytics] Regenerate with updated swagger

* add support for actionName in the response

* update changelog
… suite (#15684)

* [Text Analytics] Use test matrix

* Move healthcare to testAnalyticsClient.spec.ts
* record tests

* record browser tests

* re-record

* format

* update to the GA versio

* update README

* edit

* fix issue

* edit

* fix

* fix issue

* fix issue

* update recordings

* disable test and remove recordings
* [Text Analytics] Hide action name

* format
Because the service currently support one action only per type except for PII actions. However they plan to disable multiple actions for PII as well within a month. This PR does client-side checking for this across types and throw a meaningful error message. This limitation will be relaxed in the next service preview version.
@ghost
Copy link

ghost commented Jun 30, 2021

Hello @deyaaeldeen!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 761a4e6 into main Jun 30, 2021
@ghost ghost deleted the feature/textanalytics/3.1 branch June 30, 2021 23:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants