Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] node-fetch takes above 2 seconds to send the request on some environments #15937

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

sadasant
Copy link
Contributor

While we stopped using node-fetch on core-rest-pipeline, core-http does use it. Node fetch takes above 2 seconds to begin sending network requests in some environments. We’re able to reproduce this issue in Kubernetes pods, but it could be present elsewhere.

This PR increases the timeout to 3 seconds.

I believe this should be ok as a temporary solution, since in many cases, we will get a response (any response) before that time.

For Identity. we should be able to solve this as soon as we move Identity to core-rest-pipeline: #15595 We’re planning to do this during July. However, that won’t solve the issue in core-http.

This issue is related to: #15935

It won’t fix #15935, but it will help us have an immediate aid for our customers.

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this change, though can you file a tracking bug to remove this as part of the switch to corev2?

@sadasant
Copy link
Contributor Author

@xirzec yes yes, I’ll move this back as part of moving Identity to core-rest-pipeline: #15595

@sadasant sadasant merged commit 8919e6a into Azure:main Jun 28, 2021
@sadasant sadasant deleted the identity/increaseIMDSDefaultTimeout branch June 28, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core-http] node-fetch takes above 2 seconds to send the request on some environments
2 participants