Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Use ES2017 #15835

Merged
merged 15 commits into from
Jun 24, 2021
Merged

[Storage] Use ES2017 #15835

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
395d64d
[Storage] Use ES2017
deyaaeldeen Jun 17, 2021
7c74773
edit
deyaaeldeen Jun 17, 2021
7bf6b28
Merge remote-tracking branch 'upstream/main' into core-storage-use-es8
deyaaeldeen Jun 23, 2021
92a1a84
patch dev-tool to work with shared sources without node_modules
deyaaeldeen Jun 23, 2021
a56d389
bump core-lro version
deyaaeldeen Jun 23, 2021
981bb37
bump minor version for storage packages
deyaaeldeen Jun 23, 2021
425469a
revert version bump for storage-datalake since it does not depend on …
deyaaeldeen Jun 23, 2021
7911832
upgrade everyone to depend on core-lro@^2.0.0
deyaaeldeen Jun 23, 2021
b68a933
quantum to target ES2017
deyaaeldeen Jun 23, 2021
d563163
Revert "upgrade everyone to depend on core-lro@^2.0.0"
ramya-rao-a Jun 24, 2021
f1e5675
Revert version change for core-lro
ramya-rao-a Jun 24, 2021
9ea21a3
Better changelogs
ramya-rao-a Jun 24, 2021
0e92dca
Merge branch 'main' into pr/deyaaeldeen/15835
ramya-rao-a Jun 24, 2021
e424f29
Update changelogs for storage
ramya-rao-a Jun 24, 2021
daece93
Update storage version in other places
ramya-rao-a Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions common/tools/dev-tool/src/commands/samples/prep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ async function enableLocalRun(

let relativePath = new Array(depth).fill("..").join("/");

if (isTs) {
// TypeScript imports should use src directly
relativePath += "/src";
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done before for reasons that @witemple-msft does not remember and it is causing the storage-file-datalake samples to fail compiling because storage-common is just a simple folder of source files instead of being a package with a package.json (unlike keyvault-common) so compiled files there do not have access to tslib.

outputContent = fileContents.replace(
importRegex,
isTs ? `import $1 from "${relativePath}";` : `const $1 = require("${relativePath}");`
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@azure/communication-common": "^1.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-phone-numbers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-http/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"module": "commonjs",
"outDir": "dist",
"target": "es5",
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
"declarationDir": "./types/latest"
},
"exclude": ["node_modules"],
Expand Down
5 changes: 4 additions & 1 deletion sdk/core/core-lro/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Release History

## 1.0.6 (Unreleased)
## 2.0.0 (Unreleased)

### New Features

- compiled to target ES2017
ramya-rao-a marked this conversation as resolved.
Show resolved Hide resolved

## 1.0.5 (2021-04-12)

Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-lro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@azure/core-lro",
"author": "Microsoft Corporation",
"sdk-type": "client",
"version": "1.0.6",
"version": "2.0.0",
"description": "LRO Polling strategy for the Azure SDK in TypeScript",
"tags": [
"isomorphic",
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-lro/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es5",
"outDir": "./dist-esm",
"declarationDir": "./types"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/formrecognizer/ai-form-recognizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
"dependencies": {
"@azure/core-auth": "^1.3.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-http": "^1.2.0",
"@azure/core-tracing": "1.0.0-preview.12",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@azure/core-auth": "^1.3.0",
"@azure/core-client": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-rest-pipeline": "^1.1.0",
"@azure/core-tracing": "1.0.0-preview.12",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-secrets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
"dependencies": {
"@azure/core-auth": "^1.3.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-http": "^1.2.0",
"@azure/core-tracing": "1.0.0-preview.12",
Expand Down
1 change: 0 additions & 1 deletion sdk/quantum/quantum-jobs/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "../../../tsconfig.package",
"compilerOptions": {
"strict": true,
"target": "es5",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was needed because it depends on core-http. There is no need to bump the version I believe since it is still in beta.

"sourceMap": true,
"lib": [
"es6",
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob-changefeed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@azure/storage-blob": "^12.6.0-beta.1",
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob-changefeed/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"sourceMap": true,
"inlineSources": true,
"newLine": "LF",
"target": "es5",
"target": "ES2017",
"moduleResolution": "node",
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand Down
8 changes: 4 additions & 4 deletions sdk/storage/storage-blob/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 12.6.1 (Unreleased)
## 12.7.0 (Unreleased)

### Features Added

Expand Down Expand Up @@ -355,12 +355,12 @@
- [Breaking] The static methods to create client types are removed. The functionality is moved into new instance methods added to the parent clients.
- [Breaking] The telemetry strings have been updated.
- `Azure-Storage/${SDK_VERSION}` is updated to `azsdk-js-storagefile/${SDK_VERSION}`.
- [Breaking]  withPipeline method is removed.
- [Breaking] withPipeline method is removed.
- Async iterators with pagination support are added for listing methods
- `listContainers()`, `listBlobsFlat()` and `listBlobsByHierarchy()`
- Please refer to the samples for async iterators in the `samples` folder.
- [Breaking]  Methods that list segments(`listBlobFlatSegment()` and `listContainersSegment()`) are no longer exposed in public api.
- [Breaking]  High level convenience functions are moved into clients as their instance member function.
- [Breaking] Methods that list segments(`listBlobFlatSegment()` and `listContainersSegment()`) are no longer exposed in public api.
- [Breaking] High level convenience functions are moved into clients as their instance member function.
- `uploadFileToBlockBlob()`, `uploadStreamToBlockBlob()` and `uploadBrowserDataToBlockBlob()` -> `BlockBlobClient.uploadFile()`, `BlockBlobClient.uploadStream()` and `BlockBlobClient.uploadBrowserData()` respectively
- `downloadBlobToBuffer()` -> `BlobClient.downloadToBuffer()`
- [Breaking] `StorageClient` is no longer exposed. `StorageClient.newPipeline()` static method is moved to the top level exported function `newPipeline()`.
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@azure/storage-blob",
"sdk-type": "client",
"version": "12.6.1",
"version": "12.7.0",
"description": "Microsoft Azure Storage SDK for JavaScript - Blob",
"main": "./dist/index.js",
"module": "./dist-esm/storage-blob/src/index.js",
Expand Down Expand Up @@ -128,7 +128,7 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down
1 change: 0 additions & 1 deletion sdk/storage/storage-blob/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es5",
"declarationDir": "./typings/latest",
"outDir": "./dist-esm",
"lib": ["dom", "es5", "es6", "es7", "esnext"]
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-datalake/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"module": "es6",
"moduleResolution": "node",
"strict": true,
"target": "es5",
"target": "ES2017",
"sourceMap": true,
"declarationMap": true,
"esModuleInterop": true,
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/storage-file-datalake/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Release History

## 12.6.0 (Unreleased)

## 12.5.0 (2021-06-09)

- Includes all features released in 12.5.0-beta.1.
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-datalake/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@azure/storage-file-datalake",
"version": "12.5.0",
"version": "12.6.0",
"description": "Microsoft Azure Storage SDK for JavaScript - DataLake",
"sdk-type": "client",
"main": "./dist/index.js",
Expand Down
1 change: 0 additions & 1 deletion sdk/storage/storage-file-datalake/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es5",
"declarationDir": "./typings/latest",
"outDir": "./dist-esm",
"lib": ["dom", "es5", "es6", "es7", "esnext"]
Expand Down
6 changes: 4 additions & 2 deletions sdk/storage/storage-file-share/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Release History

## 12.7.0 (Unreleased)

## 12.6.0 (2021-06-09)

- Updated Azure Storage Service API version to 2020-08-04.
Expand Down Expand Up @@ -229,8 +231,8 @@
- Async iterators with pagination support are added for listing methods
- `listFilesAndDirectories()` and `listShares()`
- Please refer to the samples for async iterators in the `samples` folder.
- [Breaking] Methods that list segments(`listFilesAndDirectoriesSegment()` and `listSharesSegment()`) are no longer exposed in public api.
- [Breaking] High level convenience functions are moved into clients as their instance member function.
- [Breaking] Methods that list segments(`listFilesAndDirectoriesSegment()` and `listSharesSegment()`) are no longer exposed in public api.
- [Breaking] High level convenience functions are moved into clients as their instance member function.
- `uploadFileToAzureFile()`, `uploadStreamToAzureFile()`, `downloadAzureFileToBuffer()` and `uploadBrowserDataToAzureFile()` -> `FileClient.uploadFile()`,
`FileClient.uploadStream()`, `FileClient.downloadToBuffer()` and `FileClient.uploadBrowserData()` respectively.
- [Breaking] `StorageClient` is no longer exposed. `StorageClient.newPipeline()` static method is moved to the top level exported function `newPipeline()`.
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@azure/storage-file-share",
"sdk-type": "client",
"version": "12.6.0",
"version": "12.7.0",
"description": "Microsoft Azure Storage SDK for JavaScript - File",
"main": "./dist/index.js",
"module": "./dist-esm/src/index.js",
Expand Down
1 change: 0 additions & 1 deletion sdk/storage/storage-file-share/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es5",
"declarationDir": "./typings/latest",
"outDir": "./dist-esm",
"lib": ["dom", "es5", "es6", "es7", "esnext"]
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-internal-avro/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"sourceMap": true,
"inlineSources": true,
"newLine": "LF",
"target": "es5",
"target": "ES2017",
"moduleResolution": "node",
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/storage-queue/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Release History

## 12.6.0 (Unreleased)

## 12.5.0 (2021-06-09)

- Updated Azure Storage Service API version to 2020-08-04.
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@azure/storage-queue",
"sdk-type": "client",
"version": "12.5.0",
"version": "12.6.0",
"description": "Microsoft Azure Storage SDK for JavaScript - Queue",
"main": "./dist/index.js",
"module": "./dist-esm/src/index.js",
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"sourceMap": true,
"inlineSources": true,
"newLine": "LF",
"target": "es5",
"target": "ES2017",
"moduleResolution": "node",
"noUnusedLocals": true,
"noUnusedParameters": true,
Expand Down
2 changes: 1 addition & 1 deletion sdk/synapse/synapse-artifacts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/synapse/synapse-artifacts/README.md",
"repository": "github:Azure/azure-sdk-for-js",
"dependencies": {
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-http": "^1.2.0",
"@azure/core-tracing": "1.0.0-preview.12",
Expand Down
2 changes: 1 addition & 1 deletion sdk/textanalytics/ai-text-analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@azure/core-auth": "^1.3.0",
"@azure/core-client": "^1.0.0",
"@azure/core-rest-pipeline": "^1.1.0",
"@azure/core-lro": "^1.0.6",
"@azure/core-lro": "^2.0.0",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.12",
"@azure/logger": "^1.0.0",
Expand Down