update version of identity for perf tests and samples of service-bus #15632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
chradek,
deyaaeldeen,
HarshaNalluru,
jeremymeng,
maorleger,
mikeharder,
praveenkuttappan,
richardpark-msft,
sadasant,
sarangan12,
schaabs,
witemple-msft and
xirzec
as code owners
ghost
added
sadasant
reviewed
Jun 9, 2021
| [advanced_listingentities]: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/samples/v7/javascript/advanced\listingEntities.js | ||
| [advanced_sessionstate]: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/samples/v7/javascript/advanced\sessionState.js | ||
| [advanced_movingmessagestodlq]: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/samples/v7/javascript/advanced\movingMessagesToDLQ.js | ||
| [advanced_processmessagefromdlq]: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/samples/v7/javascript/advanced\processMessageFromDLQ.js |
There was a problem hiding this comment.
wait, are we sure of this path change?
There was a problem hiding this comment.
That shouldn't have happened. I just ran the script "dev-tool samples publish --force". Though the change in slash shouldn't have happened. @willmtemple
sadasant
approved these changes
Jun 9, 2021
|
Make sure CI passes, of course. |
|
/check-enforcer override |
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update version of identity for perf tests -
update version of identity for samples: