[Communication][Test] Update client secret replacement to common one #15591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can suppress CredScan errors using one single value.
jeremymeng
requested review from
0rland0Wats0n,
ankitarorabit,
DominikMe and
a team
as code owners
ghost
added
the
0rland0Wats0n
approved these changes
Jun 10, 2021
|
Thanks for the review @0rland0Wats0n |
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
…zure#15591) * [Communication][Test] Update client secret replacement to common one So that we can suppress CredScan errors using one single value. * Update recordings for communication-sms tests
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jun 22, 2021
So that we can suppress CredScan errors using one common value from eng/CredScanSuppression.json. Similar to PR Azure#15591 but for different libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can suppress CredScan errors using one common value from eng/CredScanSuppression.json.