-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convenience Method to create a synonymmap object #15129
Conversation
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great helper to add! Just a few bits of feedback before we merge this
Also can we add a test for the new method? Should be able to check in a small test collateral file like we do for core packages |
@xirzec I have fixed the comments and also added a test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test! Just a couple last pieces of feedback
sdk/search/search-documents/test/internal/synonymMap.browser.spec.ts
Outdated
Show resolved
Hide resolved
Also, there is a CI failure. I am still working on that. I will fix it and get back to you. |
/check-enforcer reset |
Closing this in favor of #16054 |
This PR is related to Issue #14664. This PR creates a convenience method that creates a synonymmap object.
A similar method is implemented in Java and could be found here: https://github.com/Azure/azure-sdk-for-java/pull/20984/files
@xirzec Please review and approve
@ramya-rao-a FYI....