Convenience Method to create a synonymmap object #15129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
No pipelines are associated with this pull request. |
xirzec
requested changes
May 4, 2021
|
Also can we add a test for the new method? Should be able to check in a small test collateral file like we do for core packages |
|
@xirzec I have fixed the comments and also added a test case. |
xirzec
requested changes
May 5, 2021
sarangan12
requested review from
EmmaZhu,
HarshaNalluru,
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
sarangan12
commented
May 5, 2021
sdk/search/search-documents/test/internal/synonymMap.browser.spec.ts
Outdated
Show resolved
Hide resolved
sarangan12
commented
May 5, 2021
|
Also, there is a CI failure. I am still working on that. I will fix it and get back to you. |
|
/check-enforcer reset |
|
Closing this in favor of #16054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to Issue #14664. This PR creates a convenience method that creates a synonymmap object.
A similar method is implemented in Java and could be found here: https://github.com/Azure/azure-sdk-for-java/pull/20984/files
@xirzec Please review and approve
@ramya-rao-a FYI....