adding a check-format step in CI #13983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
danieljurek,
mikeharder and
mitchdenny
as code owners
weshaggard
reviewed
Feb 25, 2021
This was referenced Mar 17, 2021
ghost
pushed a commit
that referenced
this pull request
Mar 17, 2021
This PR has the last set of formatting changes for us to enable the fomatting checks in CI in #13983
|
Hello @deyaaeldeen! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
praveenkuttappan
approved these changes
Mar 17, 2021
ghost
merged commit
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
This PR has the last set of formatting changes for us to enable the fomatting checks in CI in Azure#13983
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
Adds a new analyze step to run `rushx check-format` in the package the opened PR is against. We are doing this after killing the git precommit hook that used to run the formatter here: Azure#13982. I am not very familiar with engineering systems scripts so I might have missed something.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new analyze step to run
rushx check-formatin the package the opened PR is against. We are doing this after killing the git precommit hook that used to run the formatter here: #13982. I am not very familiar with engineering systems scripts so I might have missed something.