Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Allow linter errs to break build #13920

Merged
3 commits merged into from
Feb 22, 2021
Merged

[Event Hubs] Allow linter errs to break build #13920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
925ea9b
[Event Hubs] Allow linter errs to break build
ramya-rao-a Feb 22, 2021
d7f2797
Merge remote-tracking branch 'origin' into eh-enable-lint
ramya-rao-a Feb 22, 2021
6cadfbe
Fix error from the latest linter rule
ramya-rao-a Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace dist-esm/test/internal/*.spec.js dist-esm/test/public/*.spec.js dist-esm/test/public/**/*.spec.js dist-esm/test/internal/**/*.spec.js",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json api-extractor.json src test --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
"lint": "eslint package.json api-extractor.json src test --ext .ts",
"pack": "npm pack 2>&1",
"perf-test:node": "tsc -p . --module \"commonjs\" && node dist-esm/test/perf/track-2/index.spec.js",
"prebuild": "npm run clean",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/test/internal/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ function getAbortSignalWithTracking(
): AbortSignalLike & { ourListenersWereRemoved(): boolean } {
const signal = (abortController.signal as any) as ReturnType<typeof getAbortSignalWithTracking>;

const allFunctions = new Set<Function>();
const allFunctions = new Set();

const origAddEventListener = signal.addEventListener;
const origRemoveEventListener = signal.removeEventListener;
Expand Down
4 changes: 2 additions & 2 deletions sdk/eventhub/event-hubs/test/public/utils/testUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { NoOpTracer, TestTracer, setTracer } from "@azure/core-tracing";

dotenv.config();

declare const window: any;
declare const self: any;

export const isNode =
!!process && !!process.version && !!process.versions && !!process.versions.node;
Expand All @@ -26,7 +26,7 @@ function getEnvVarValue(name: string): string | undefined {
if (isNode) {
return process.env[name];
} else {
return window.__env__[name];
return self.__env__[name];
}
}

Expand Down