Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] Centralize (as much as is practical) the creation of spans to ease upgrades #13887

Merged
merged 55 commits into from
Feb 26, 2021

Commits on Feb 19, 2021

  1. Centralize createSpan code into core-tracing, update the minimum need…

    …ed for core-tracing to compile and test
    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    2ccc04f View commit details
    Browse the repository at this point in the history
  2. Formatting

    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    d00744f View commit details
    Browse the repository at this point in the history
  3. Updating the package reference to be the new core-tracing version (wh…

    …ich will shortly have a new OT)
    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    96f7c97 View commit details
    Browse the repository at this point in the history
  4. Formatting

    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    13d5b35 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    450e1ba View commit details
    Browse the repository at this point in the history
  6. Formatting

    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    88b5783 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    724092a View commit details
    Browse the repository at this point in the history
  8. Formatting

    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    7092a57 View commit details
    Browse the repository at this point in the history
  9. Service Bus was using the properties from createSpan() with a differe…

    …nt name. Not sure why I didn't see this earlier.
    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    df7f0e1 View commit details
    Browse the repository at this point in the history
  10. Formatting

    richardpark-msft committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    cca3325 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Remove unneeded OperationTracingOptionsLike (the same package already…

    … had OperationTracingOptions!)
    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    89da87e View commit details
    Browse the repository at this point in the history
  2. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    fd10725 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b00a413 View commit details
    Browse the repository at this point in the history
  4. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    ee2b382 View commit details
    Browse the repository at this point in the history
  5. Update storage-blob for the pending update to the latest OpenTelemetr…

    …y. Prior to this change `createSpan` would create a new SpanOptions, out of a OperationTracingOptions (basically). This works today but will break when we move to a later version of opentelemetry, where the necessary information to track is actually two separate fields.
    
    To make this simpler we have a createSpanFunction that can handle doing the proper updating of the `tracingOptions ` property of an OperationOptions compatible type. Converting any code over to this style should future proof us a bit.
    
    In storage-blob the changes I've made here are:
    - If the call takes an OperationOptions, try to pass the updatedOptions directly, or if extensive copying/mutation was occuring - just pass operationOptions.tracingOptions instead.
    
    So this code:
    
    ```
              {
                  ...options,
                  tracingOptions: { ...options!.tracingOptions, spanOptions }
                }
    ```
    
    Becomes
    
    ```
    updatedOptions (which came back from core-tracing's createSpan function)
    ```
    
    - If the underlying call takes RequestOptionsBase then we call ...convertTracingToRequestOptionsBase(updatedOptions) which should allow me room to just change _that_ function when the number of fields to copy over changes.
    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    2aea35c View commit details
    Browse the repository at this point in the history
  6. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    4dc72d8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    42ff058 View commit details
    Browse the repository at this point in the history
  8. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    6f99488 View commit details
    Browse the repository at this point in the history
  9. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    ee8c6f0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7edc5dd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    63b013d View commit details
    Browse the repository at this point in the history
  12. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    68c5ce0 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7031b79 View commit details
    Browse the repository at this point in the history
  14. Formatting

    richardpark-msft committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    4bd5363 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    b9c51e6 View commit details
    Browse the repository at this point in the history
  2. Formatting

    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6365b72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f645aec View commit details
    Browse the repository at this point in the history
  4. - createSpa now guarantees it's return value is not null (eliminates …

    …some more code doing <blah> || {}
    
    - synapse-artifacts: fixing a .tracingOptions slicing issue where RequestOptionsBase was being passed to createSpan, which expected an OperationOptions.
    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    4b0e99e View commit details
    Browse the repository at this point in the history
  5. Formatting

    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    3404d31 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7887702 View commit details
    Browse the repository at this point in the history
  7. Formatting

    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5a71f92 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e86b11d View commit details
    Browse the repository at this point in the history
  9. Formatting

    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    36e30c1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5e3fada View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fc4e05f View commit details
    Browse the repository at this point in the history
  12. Formatting

    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    3785e5e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    00cbaba View commit details
    Browse the repository at this point in the history
  14. our semver rule was tripping over using preview.10 as the version. Ju…

    …st switching over to -beta.1, which is what it as upgraded to originally.
    richardpark-msft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    81d17b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Bring back a compatible createSpan function so we don't cause runtime…

    … issues in already released packages that might upgrade to this core-http version.
    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b48f98c View commit details
    Browse the repository at this point in the history
  2. After talking with @joheredi it's obvious we can't remove this functi…

    …on as it'd cause errors in existing packages that update to the latest core-http. Will have to reserve for a major version update.
    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    5cf9288 View commit details
    Browse the repository at this point in the history
  3. Formatting

    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0b5e2d6 View commit details
    Browse the repository at this point in the history
  4. Change name from SpanConfig (which is too generic!) to CreateSpanFunc…

    …tionArgs, which is hyper-specific and cannot be confused for anything but the arguments for createSpanFunction
    
    Also, added some doc comments to createSpanFunction
    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    bd1a4e8 View commit details
    Browse the repository at this point in the history
  5. Formatting again.

    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b168a32 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bed4e50 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    af57992 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bf06056 View commit details
    Browse the repository at this point in the history
  9. Formatting

    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0e3b80f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4900eb1 View commit details
    Browse the repository at this point in the history
  11. Formatting

    richardpark-msft committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    caf7f63 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7f7ecc5 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    fe61219 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8dd23b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f62518 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fce3238 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    72d141f View commit details
    Browse the repository at this point in the history