Azure · maorleger · Jan 19, 2021 · Jan 13, 2021 · Jan 14, 2021 · Jan 15, 2021
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -62,7 +62,7 @@
 /sdk/identity/ @schaabs @daviwil @jonathandturner @sadasant
 
 # PRLabel: %KeyVault
-/sdk/keyvault/ @jonathandturner @sadasant
+/sdk/keyvault/ @jonathandturner @sadasant @maorleger
 
 # PRLabel: %Storage
 /sdk/storage/ @XiaoningLiu @jeremymeng @HarshaNalluru @vinjiang @jiacfan @ljian3377

diff --git a/.gitignore b/.gitignore
@@ -118,6 +118,7 @@ Thumbs.db
 *.cer
 *.pfx
 *.pem
+*.key
 
 # WebStorm #
 .idea/

diff --git a/sdk/keyvault/keyvault-admin/package.json b/sdk/keyvault/keyvault-admin/package.json
@@ -71,7 +71,7 @@
     "test:node": "npm run clean && npm run build:test && npm run unit-test:node",
     "test": "npm run clean && npm run build:test && npm run unit-test",
     "unit-test:browser": "echo skipped",
-    "unit-test:node": "echo skipped",
+    "unit-test:node": "mocha --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 180000 --full-trace dist-test/index.node.js",
     "unit-test": "npm run unit-test:node && npm run unit-test:browser",
     "docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --stripInternal --mode file --out ./dist/docs ./src"
   },

diff --git a/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_createroleassignment.js b/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_createroleassignment.js
diff --git a/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_deleteroleassignment.js b/...borting_keyvaultaccesscontrolclients_requests/recording_can_abort_deleteroleassignment.js
diff --git a/...e/aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_getroleassignment.js b/...e/aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_getroleassignment.js
diff --git a/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroleassignments.js b/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroleassignments.js
diff --git a/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroledefinitions.js b/...aborting_keyvaultaccesscontrolclients_requests/recording_can_abort_listroledefinitions.js
diff --git a/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js b/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js
diff --git a/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js b/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js
diff --git a/...ticate_tests/recording_should_skip_unexpected_properties_on_the_wwwauthenticate_header.js b/...ticate_tests/recording_should_skip_unexpected_properties_on_the_wwwauthenticate_header.js
diff --git a/...uthenticate_tests/recording_should_work_for_known_shapes_of_the_wwwauthenticate_header.js b/...uthenticate_tests/recording_should_work_for_known_shapes_of_the_wwwauthenticate_header.js