-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Moving Azure/azure-storage-js repo #1316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support version in package.json
…est-js; Removed meatada for pageblobincrementalcopy
* Rollup, tsconfig fixes, externalize auto-rest, tslib * Add rollup config * Update rollup config; produce browser build * tsconfig.json: enable esModuleInterop, set module to esNext * Update package.json browser field * Update npm ignore to include original source * Clean up package.json, fix build * Updates to make webpack tree-shake appropriately * Rollup for tests, including browsers * Update gitignore * Change global name to azblob * Use isNode in bloburl test * Update .npmignore * clean up clean task * Remove node-builtins and node-globals in favor of explict shims
* Remove deep import of ms-rest-js types * Fix quoting
HarshaNalluru
added
Client
This issue points to a problem in the data-plane of the library.
Storage
Storage Service (Queues, Blobs, Files)
labels
Feb 21, 2019
HarshaNalluru
requested review from
jeremymeng,
AlexGhiondea,
mikeharder and
ramya-rao-a
February 21, 2019 22:47
ghost
added
the
in progress
label
Feb 21, 2019
jeremymeng
requested changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add names of all three packages here:
"@azure/storage-blob",
"@azure/storage-file",
"@azure/storage-queue",
Can you squash the last two commits of "disable the automatic publishing for storage package"? Since we will use the |
HarshaNalluru
force-pushed
the
MovingStorage
branch
from
February 22, 2019 01:18
1eb9143
to
508a74f
Compare
jeremymeng
approved these changes
Feb 22, 2019
ghost
removed
the
in progress
label
Mar 12, 2019
HarshaNalluru
added a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
[Storage] Moving Azure/azure-storage-js repo - Merge pull request Azure#1316 from HarshaNalluru/MovingStorage
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving azure-storage-js into the
packages/@azure/storage
folder