[ESLint plugin] Deprecate support for preview and dev versions - Attempt 2 #12685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
xirzec,
willmtemple,
jeremymeng,
weshaggard,
mikeharder,
ramya-rao-a and
chradek
mikeharder
approved these changes
Dec 1, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 29, 2021
Add ChangeFeed retention in June19 and Aug20-preview version (Azure#12685)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR:
rush lintsucceeds locally this timeI opened #12606 before to do the same thing but it caused failures because
core-tracingdoes not follow the new policy on semvar, so we had to revert it here: #12634. I opened #12683 to updatecore-tracingto usebetainstead ofpreviewbased on @ramya-rao-a recommendation here: #10987 (comment).There are other packages that still use
previewinstead ofbetabut you can find an explanation why this would not cause failures here: #10987 (comment).Fixes #10987.
Blocked on #12683.