[WIP] Debug Perf test/framework with storage-blob #12653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing since the issue is resolved. |
ghost
pushed a commit
that referenced
this pull request
Dec 2, 2020
Reference - #12653 This PR mainly focuses on - improving the type inference for the options(uses typescript magic to achieve it) - introduces a new parsedOptions that can be consumed in the tests rather than overriding and consuming the original options bag - required for #12737 which adds tests for storage-blob Any issues with the functionality of the options or otherwise will be caught while we add new tests in upcoming PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO REPRO
test-utils/perfstress/folder withACCOUNT_NAMEandACCOUNT_KEYvariablesrush update && rush build -t test-utils-perfstressrushx build && npm run perfstress-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2 --parallel 2rushx build && npm run perfstress-test:node -- StorageBlobDownloadTest --warmup 2 --duration 7 --iterations 2