fix the description of visibilityTimeout in MessagesEnqueueOptionalPa… #12189
Conversation
ljian3377
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
ghost
added
the
| @@ -107,6 +107,10 @@ directive: | |||
| where: $.parameters.VisibilityTimeoutRequired | |||
| transform: > | |||
| $["x-ms-client-name"] = "visibilityTimeout"; | |||
| - from: swagger-document | |||
| where: $.parameters.VisibilityTimeoutForEnqueue | |||
There was a problem hiding this comment.
I am a little surprised that without the swagger transformation, the codegen will pick the documentation from another parameter. @joheredi can you have a look to see whether it's expected behavior in autorest?
There was a problem hiding this comment.
Actually I also updated the swagger to fix this. We used the same paramter for the two parmeters in enqueue and dequeue in the swagger, while their descriptions should be different. So I think the codegen is working as expected.
Azure/azure-rest-api-specs#11459
There was a problem hiding this comment.
It looks like the Swagger already sets the x-ms-client-name to "visibilityTimeout". Do we need to have it here as well?
There was a problem hiding this comment.
The "x-ms-client-name": "visibilityTimeout" in swagger is removed in Azure/azure-rest-api-specs#11461.
Other languages use a different casing so we have to do it in our own README.md.
…rams
Fixes #8302