[MetricsAdvisor,test] Fix listing datafeed live tests #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a scenario to rename the datafeed so the listing by the "js-test" prefix would only return one result thus break listing tests' assumption. Fixed by moving listing to after creating three data feeds so we still have two data feeds with "js-test" prefix.
KarishmaGhiya
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a scenario to rename a data feed so the listing by the
"js-test" prefix would only return one result thus break listing
tests' assumption of at least two results.
Fixed by moving listing to after creating three data feeds so we still
have two data feeds with "js-test" prefix.