Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[schema registry] Update to latest swagger #11650

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[schema registry] Update to latest swagger #11650

merged 2 commits into from
Oct 6, 2020

Conversation

nguerrera
Copy link
Contributor

@nguerrera nguerrera commented Oct 5, 2020 •
edited
Loading

Update to latest swagger for schema registry and react to changes.

The new swagger uses text/plain for schema where the old one used a JSON string. This had an upside and a downside.

@nguerrera nguerrera mentioned this pull request Oct 5, 2020
Closed
@nguerrera nguerrera added Schema Registry Client This issue points to a problem in the data-plane of the library. labels Oct 5, 2020
@nguerrera nguerrera marked this pull request as ready for review October 5, 2020 22:20
xirzec
xirzec approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a fine update. text/plain APIs are always a little funny, but it's good that you found misbehavior on the server-side!

@nguerrera nguerrera merged commit 2c57c8e into Azure:master Oct 6, 2020
@nguerrera nguerrera deleted the update-swagger branch October 6, 2020 19:54
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jan 6, 2021
@nimaller @richajain
@abhi7860 @harics24 @Nilambari @wdehrich @Kawilki-M @wangxu724
CodeGen from PR 12278 in Azure/azure-rest-api-specs
fb819a9 
Network august release (Azure#12278)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (Azure#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (Azure#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (Azure#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (Azure#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (Azure#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (Azure#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (Azure#12299)

Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 4, 2021
@nikhilpadhye1 @saisujithreddym
@nimaller @richajain @abhi7860 @harics24 @Nilambari @wdehrich @Kawilki-M @wangxu724 @irrogozh @akshatkale @litchiyangMSFT @zhenglaizhang @neethirshetty
CodeGen from PR 13224 in Azure/azure-rest-api-specs
af0a953 
Network november release (Azure#13224)

* Adds base for updating Microsoft.Network from version stable/2020-08-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* No snat firewall policy (Azure#12505)

* Adding No SNAT feature support to firewall policy

* committing prettier-fix

* adding period at end of description to prevent failure for checks

* Insights on Firewall Policy (Azure#12509)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (Azure#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (Azure#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (Azure#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (Azure#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (Azure#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (Azure#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (Azure#12299)

* resolving conflicts

* resolving conflicts

* new api version

* resolving conflicts

* fixing network validation

* running prettier

* fixing network valdiation

* fixing network valdiation

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Firewall Policy Insights with region (Azure#12711)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (Azure#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (Azure#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (Azure#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (Azure#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (Azure#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (Azure#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (Azure#12299)

* resolving conflicts

* resolving conflicts

* new api version

* resolving conflicts

* fixing network validation

* running prettier

* fixing network valdiation

* fixing network valdiation

* Passing in the regions to backend

* changed the reference definition

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Support for Listing IKE Security Associations for VPN Link Connections (Azure#12305)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (Azure#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (Azure#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (Azure#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (Azure#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (Azure#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (Azure#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (Azure#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (Azure#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (Azure#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (Azure#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (Azure#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (Azure#12299)

* Adding getikesas for vpn link connections

* pretty fix

* Naming

* Update VpnSiteLinkConnectionGetIkeSas.json

* Update VpnSiteLinkConnectionGetIkeSas.json

* Changing API version

* Update readme.md

* Updating API version

* Removing changes from older API

* Update virtualWan.json

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Added 'Subnet' property to LoadBalancerBackendAddress (Azure#12625)

* Support for ResetConnection for VNG and VPN Link connections (Azure#12715)

* fix the name mismatch (Azure#12826)

* Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903)

* Add support for Traffic selector param in Connection - initial changes

* Add trafficSelectorPolicies list in responses

* Add trafficSelectorPolicies list in Get and List connection

* cleanup stostools (Azure#12699)

* Revert "Merge branch 'network-november-release' into ak-traffic-selector"

This reverts commit 1a8f61e3c4395f410d6ff16ee41da4d2eeb091b5, reversing
changes made to 3c90ff8ccb6c1e46c0480643906d6b5c5388e8c8.

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>

* Revert "Add support for Traffic selector param in VpnConnection for virtualWan" (Azure#13088)

* Revert "Add support for Traffic selector param in VpnConnection for virtualWan (Azure#12903)"

This reverts commit 34dcf04f0ee453fa739ec2f790376a8decb5a3ab.

* cleanup stostools (Azure#12699)

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>

* Re - Add support for Traffic selector param in VpnConnection for virtualWan (Azure#13103)

* Add support for Traffic selector param in Connection - initial changes

* Add trafficSelectorPolicies list in responses

* Add trafficSelectorPolicies list in Get and List connection

* add auth type property to vng config (Azure#13183)

* added reverted by mistake api version

* fixed mistyping

* Fix name mismatch for virtual network local gateway (Azure#13266)

* fix the name mismatch

* fix name mismatch in nov

Co-authored-by: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com>
Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Co-authored-by: Akshat Kale <kaleakshat@gmail.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: neethirshetty <75816269+neethirshetty@users.noreply.github.com>
@nguerrera nguerrera mentioned this pull request May 5, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguerrera @xirzec