[Identity] Changelog updates before releasing #11646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sadasant
commented
Oct 5, 2020
| @@ -1,6 +1,6 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.2.0-beta.2 (Unreleased) | |||
| ## 1.2.0-beta.2 (2020-10-05) | |||
|
|
|||
There was a problem hiding this comment.
David and I were talking about what could go to the release highlights from these changes. We've agreed on the first three items so far.
So, this would be in the release highlights:
DefaultAzureCredentialnow by default shows the Device Code message on the console. This can still be overwritten with a custom behavior by specifying a function as the third parameter,userPromptCallback.- Added support for multiple clouds on
VisualStudioCodeCredential. Fixes customer issue 11452. ManagedIdentityCredentialhas been aligned with other languages, now treating expected errors properly. This fixes customer issue 11451.- Added Active Directory Federation Services authority host support to the node credentials.
Thoughts?
There was a problem hiding this comment.
Added ADFS authority Host support to the node credentials.
daviwil
approved these changes
Oct 5, 2020
Two updates on the CHANGELOG based on recent PRs.
sadasant
commented
Oct 5, 2020
|
|
||
| - `DefaultAzureCredential` now by default shows the Device Code message on the console. This can still be overwritten with a custom behavior by specifying a function as the third parameter, `userPromptCallback`. | ||
| - Added support for multiple clouds on `VisualStudioCodeCredential`. Fixes customer issue [11452](https://github.com/Azure/azure-sdk-for-js/issues/11452). | ||
| - `ManagedIdentityCredential` has been aligned with other languages, now treating expected errors properly. This fixes customer issue [11451](https://github.com/Azure/azure-sdk-for-js/issues/11451). | ||
| - `InteractiveBrowserCredential` authentication now uses the silent flow if the user provides a cache and authentication record for lookup. |
There was a problem hiding this comment.
This comes from: #11407
There was a problem hiding this comment.
I think this is the only important change for now, since Jonathan is working on further improvements. I could have missed something though.
sadasant
commented
Oct 5, 2020
sdk/identity/identity/CHANGELOG.md
Outdated
|
|
||
| - `DefaultAzureCredential` now by default shows the Device Code message on the console. This can still be overwritten with a custom behavior by specifying a function as the third parameter, `userPromptCallback`. | ||
| - Added support for multiple clouds on `VisualStudioCodeCredential`. Fixes customer issue [11452](https://github.com/Azure/azure-sdk-for-js/issues/11452). | ||
| - `ManagedIdentityCredential` has been aligned with other languages, now treating expected errors properly. This fixes customer issue [11451](https://github.com/Azure/azure-sdk-for-js/issues/11451). | ||
| - `InteractiveBrowserCredential` authentication now uses the silent flow if the user provides a cache and authentication record for lookup. | ||
| - Added Active Directory Federation Services support. This behavior happens automatically, without user intervention. |
There was a problem hiding this comment.
This comes from: #11591
There was a problem hiding this comment.
adfs is Active Directory Federation Services, right?
|
This also changed: But it's a very internal thing, and an additive change that won't break anybody's code. I wonder if we should not add it to the changelog. |
sadasant
changed the title
sadasant
changed the title
g2vinay
reviewed
Oct 5, 2020
g2vinay
approved these changes
Oct 5, 2020
ramya-rao-a
approved these changes
Oct 5, 2020
sadasant
added a commit
to Azure/azure-sdk
that referenced
this pull request
Oct 5, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 16, 2020
Adding Identity to Patch Vault (Azure#11646)
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up the release date for Identity as Tomorrow just to give me some range of action.
I also added some changelog entries that were missing. Feedback appreciated! ✨