[Text Analytics] Does not ignore ts-naming options #11506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
reviewed
Sep 25, 2020
sdk/textanalytics/ai-text-analytics/review/ai-text-analytics.api.md
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Sep 25, 2020
| @@ -176,9 +176,6 @@ export enum PiiEntityDomainType { | |||
| // @public | |||
| export type RecognizeCategorizedEntitiesErrorResult = TextAnalyticsErrorResult; | |||
|
|
|||
| // @public | |||
| export type RecognizeCategorizedEntitiesOptions = TextAnalyticsOperationOptions; | |||
There was a problem hiding this comment.
Removing the type would be breaking change. Someone might be using this type in their code and after updating to the latest, their code will fail to build
There was a problem hiding this comment.
ah right, I am not too bothered by it so will close for now.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 4, 2020
[Hub Generated] Review request for Microsoft.Authorization to add version preview/2020-04-01-preview (Azure#11506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring
ts-naming-optionsfor no good reason as far as I can tell here so I did the fix and re-enabling the rule in those places again.