-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema registry] set release date and update README #11116
Conversation
@@ -1,5 +1,5 @@ | |||
# Release History | |||
|
|||
## 1.0.0-beta.1 (Unreleased) | |||
## 1.0.0-beta.1 (2020-09-08) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to ask, is this the correct release date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still hoping to push the package today, but if that doesn't happen, talking @ramya-rao-a, it didn't seem like a problem if this is a day or two earlier than the real date.
coverage over nightly CI runs per engsys team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only, looks great!
header with schema ID. Uses [SchemaRegistryClient](../schema-registry) to get | ||
schema IDs from schema content or vice versa. | ||
header with schema ID. Uses | ||
[SchemaRegistryClient](https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/schemaregistry/schema-registry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future we should make this a link to the reference docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added note to #10950
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
/check-enforcer evaluate |
/check-enforcer override |
/check-enforcer evaluate |
/check-enforcer reset |
Set changelog release date and update README:
EDIT: Removed tests.yml changes from this PR as there is no additional coverage over nightly CI if we run in playback, I will start a new PR with tests.yml when service is ready.