Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schema registry] set release date and update README #11116

Merged
merged 8 commits into from
Sep 8, 2020

Conversation

nguerrera
Copy link
Contributor

@nguerrera nguerrera commented Sep 8, 2020

Set changelog release date and update README:

  • aka.ms link for setting up service (will get populated later)
  • correct logging info
  • removed unnecessary header and clean up some text in credentials part

EDIT: Removed tests.yml changes from this PR as there is no additional coverage over nightly CI if we run in playback, I will start a new PR with tests.yml when service is ready.

@@ -1,5 +1,5 @@
# Release History

## 1.0.0-beta.1 (Unreleased)
## 1.0.0-beta.1 (2020-09-08)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to ask, is this the correct release date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still hoping to push the package today, but if that doesn't happen, talking @ramya-rao-a, it didn't seem like a problem if this is a day or two earlier than the real date.

@nguerrera nguerrera changed the title [schema registry] set release date and add nightly test pipeline [schema registry] set release date and update README Sep 8, 2020
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, looks great!

header with schema ID. Uses [SchemaRegistryClient](../schema-registry) to get
schema IDs from schema content or vice versa.
header with schema ID. Uses
[SchemaRegistryClient](https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/schemaregistry/schema-registry)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future we should make this a link to the reference docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added note to #10950

sdk/schemaregistry/schema-registry-avro/README.md Outdated Show resolved Hide resolved
sdk/schemaregistry/schema-registry/README.md Outdated Show resolved Hide resolved
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
@ramya-rao-a
Copy link
Contributor

/check-enforcer evaluate

@ramya-rao-a
Copy link
Contributor

/check-enforcer override

@KarishmaGhiya
Copy link
Contributor

/check-enforcer evaluate

@weshaggard
Copy link
Member

/check-enforcer reset

@weshaggard weshaggard merged commit f0d4941 into Azure:master Sep 8, 2020
@nguerrera nguerrera deleted the sr-nightly branch September 9, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants