Rename package to "digital-twins" #11045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 3, 2020 12:28
zolvarga
requested review from
bterlson,
danieljurek,
KarishmaGhiya,
mikeharder,
ramya-rao-a and
xirzec
as code owners
sadasant
reviewed
Sep 4, 2020
| @@ -157,7 +157,7 @@ | |||
| "path": "sdk/test-utils/perfstress" | |||
| }, | |||
| { | |||
| "path": "sdk/digitaltwins/digitaltwins" | |||
| "path": "sdk\\digitaltwins\\digital-twins" | |||
There was a problem hiding this comment.
sadasant
reviewed
Sep 4, 2020
| @@ -169,7 +169,7 @@ const addOperationSpec: coreHttp.OperationSpec = { | |||
| path: "/models", | |||
| httpMethod: "POST", | |||
| responses: { | |||
| 200: { | |||
| 201: { | |||
There was a problem hiding this comment.
Yes, this is generated code using the latest swagger
In reply to: 483755756 [](ancestors = 483755756)
sadasant
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Looks good to me! Seems like a clean PR. Please don't merge until at least @praveenkuttappan approves. Also, ensure others review this if they are part of this process (I'm not fully in context).
praveenkuttappan
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.