Change prerelease versioning #10975
Change prerelease versioning #10975
Conversation
weshaggard
requested review from
danieljurek,
KarishmaGhiya,
mikeharder,
mitchdenny and
ramya-rao-a
as code owners
@sadasant @KarishmaGhiya any ideas why eslint is complaining about this semver? |
|
@weshaggard I think it is failing by this ESLint check on version format. |
|
The actual rule is a few lines below in https://github.com/Azure/azure-sdk-for-js/blob/master/common/tools/eslint-plugin-azure-sdk/src/rules/ts-versioning-semver.ts#L67 Updating the regex there should fix the problem |
|
@weshaggard The linter has been updated in #10986 to allow all 4 options of preview, beta, dev and alpha. Can you you revert your commit? We need to support "preview" until all the current previews move to beta which will take a while cc @deyaaeldeen |
| @@ -48,7 +48,7 @@ const commitChanges = async (rushPackages, package) => { | |||
| const updatePackageVersion = (rushPackages, package, buildId) => { | |||
| const currentVersion = rushPackages[package].json.version; | |||
| const parsedVersion = semver.parse(currentVersion); | |||
| rushPackages[package].newVer = `${parsedVersion.major}.${parsedVersion.minor}.${parsedVersion.patch}-dev.${buildId}`; | |||
| rushPackages[package].newVer = `${parsedVersion.major}.${parsedVersion.minor}.${parsedVersion.patch}-alpha.${buildId}`; | |||
There was a problem hiding this comment.
@weshaggard is buildId here still a date? is this what we want?
There was a problem hiding this comment.
Yes see the guidance at https://azure.github.io/azure-sdk/policies_releases.html#javascript. The alpha builds will still be date based.
I will sync his changes and fix the one issue about the version number needing to be date based. |
- Use alpha instead of dev - Use beta instead of preview
weshaggard
force-pushed
the
TestAlphaBeta
branch
from
00492aa to
288bf72
Compare
|
@weshaggard I fixed the issue with alpha versions in the linter here: #10998. |
|
@deyaaeldeen thanks I will remove that from my PR then. |
weshaggard
force-pushed
the
TestAlphaBeta
branch
from
288bf72 to
80d3757
Compare
Updating versioning logic to match guideline update in Azure/azure-sdk#1536.
PTAL @ramya-rao-a @xirzec @praveenkuttappan