Open
Description
openedon May 16, 2024
Now that we have multiple versions of core-tracing being used side-by-side the supportsTracing helper has been failing - test-utils will set the tracer on version N, but the client package uses the tracer on version N+1
To resolve this, we want to:
- Add Instrumenter to
tracingOptions
in core-tracing - Pass the
mockInstrumenter
instance from test-utils through the tracing client - Use that instance when it is provided
Then, each client can instantiate its own tracingClient passing the instrumenter through and allowing us to ensure the same instance is shared across versions.
It would be nice if we can hook this into the recorder.configureClientOptions call to avoid having to patch the instrumenter in every test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment