Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenTelemetry Instrumentation] Rush update failing in nightly runs #21140

Closed
v-jiaodi opened this issue Apr 1, 2022 · 1 comment
Closed

[OpenTelemetry Instrumentation] Rush update failing in nightly runs #21140

v-jiaodi opened this issue Apr 1, 2022 · 1 comment
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-triage Workflow: This issue needs the team to triage. test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

v-jiaodi commented Apr 1, 2022

OpenTelemetry Instrumentation nightly test runs are failing with:

Stack trace:
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies
.
└─┬ @rush-temp/azure-opentelemetry-instrumentation-azure-sdk-test
├─┬ @opentelemetry/sdk-trace-base
│ ├── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
│ ├─┬ @opentelemetry/core
│ │ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
│ └─┬ @opentelemetry/resources
│ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
└─┬ @opentelemetry/sdk-trace-node
├── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
├─┬ @opentelemetry/context-async-hooks
│ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
├─┬ @opentelemetry/propagator-b3
│ └── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0
└─┬ @opentelemetry/propagator-jaeger
└── ✕ unmet peer @opentelemetry/api@">=1.0.0 <1.1.0": found 1.1.0

For more details check here:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 1, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-triage Workflow: This issue needs the team to triage. labels Apr 1, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 1, 2022
@v-xuto v-xuto added the test-reliability Issue that causes tests to be unreliable label Apr 1, 2022
@maorleger maorleger mentioned this issue Apr 28, 2022
Merged
3 tasks
maorleger added a commit that referenced this issue Apr 28, 2022
@maorleger
[opentelemetry] - Bump otel API min-version (#21671)
2d96368 
### Packages impacted by this PR
opentelemetry-instrumentation-azure-sdk

### Issues associated with this PR
#21140

### Describe the problem that is addressed by this PR
OTel uses peer dependencies to request a version of @opentelemetry/api that is
compatible with their SDK. In min testing, that peer version is 1.0.2, so we
want to bump our min-version here as well.

This doesn't resolve the max part of min/max but I believe the next rush update
--full when merged will resolve it.
@maorleger
Copy link
Member

Fixed with #21671

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-triage Workflow: This issue needs the team to triage. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maorleger @azure-sdk @v-xuto @v-jiaodi