Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Grid] Build test package failing in nightly runs #20014

Closed
v-jiaodi opened this issue Jan 24, 2022 · 0 comments · Fixed by #20126
Closed

[Event Grid] Build test package failing in nightly runs #20014

v-jiaodi opened this issue Jan 24, 2022 · 0 comments · Fixed by #20126
Assignees
@ellismg
Labels
Client This issue points to a problem in the data-plane of the library. Event Grid test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

Event Grid nightly test runs are failing with:

Error message:
Executing: "tsc -p ."
eventGridClient.spec.ts(59,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(59,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
The types of 'request.body' are incompatible between these types.
Type 'import("/mnt/vss/_work/1/s/sdk/core/core-rest-pipeline/types/latest/core-rest-pipeline").RequestBodyType | undefined' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-rest-pipeline@1.4.0/node_modules/@azure/core-rest-pipeline/types/latest/core-rest-pipeline").RequestBodyType | undefined'.
Type 'ReadableStream' is not assignable to type 'RequestBodyType | undefined'.
Type 'ReadableStream' is missing the following properties from type 'ReadableStream': readable, read, setEncoding, pause, and 22 more.
eventGridClient.spec.ts(89,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(167,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(197,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(223,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(315,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
eventGridClient.spec.ts(341,38): error TS2322: Type 'import("/mnt/vss/_work/1/s/sdk/core/core-client/types/latest/core-client").FullOperationResponse' is not assignable to type 'import("/mnt/vss/_work/1/s/common/temp/node_modules/.pnpm/@Azure+core-client@1.4.0/node_modules/@azure/core-client/types/latest/core-client").FullOperationResponse'.
The script failed with exit code 2

For more details check here:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 24, 2022
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Event Grid test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 24, 2022
ellismg added a commit to ellismg/azure-sdk-for-js that referenced this issue Jan 28, 2022
@ellismg
[eventgrid] Fix nightly Min/Max CI issues
ef491d2 
Similar to Azure#19862, we have recently started to see some issues in our
nightly min/max jobs that prevent us from saving the entire Response
object during the `onResponse` callback due to multiple imports of the
"same" type.

Similar to the resolution for Azure#19862, I've decided to just not use
nominal types from `core-client` here and instead just stash away the
parts of the response I need inside the callback and observe the
values after.

Fixes Azure#20014
@ellismg ellismg mentioned this issue Jan 28, 2022
Merged
ellismg added a commit that referenced this issue Jan 29, 2022
@ellismg
[eventgrid] Fix nightly Min/Max CI issues (#20126)
e4c7110 
Similar to #19862, we have recently started to see some issues in our
nightly min/max jobs that prevent us from saving the entire Response
object during the `onResponse` callback due to multiple imports of the
"same" type.

Similar to the resolution for #19862, I've decided to just not use
nominal types from `core-client` here and instead just stash away the
parts of the response I need inside the callback and observe the
values after.

Fixes #20014
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ellismg ellismg

Labels
Client This issue points to a problem in the data-plane of the library. Event Grid test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[eventgrid] Fix nightly Min/Max CI issues ellismg/azure-sdk-for-js
3 participants
@ellismg @v-xuto @v-jiaodi