Azure Remote Rendering Readme and Samples Issue

[v-jiaodi]

Section link1,link2:

Reason:
The parameter format of DeviceCodeCredential should be object.

Suggestion:
Update to

let credential = new DeviceCodeCredential({tenantId, clientId, userPromptCallback:deviceCodeCallback, 
    authorityHost: "https://login.microsoftonline.com/" + tenantId
  });

@ramya-rao-a and @MalcolmTyrrell for notification.

[ramya-rao-a]

@MalcolmTyrrell Ideally, we don't list the examples showing the different credentials from @azure/identity in the readme or in the individual samples. The preference is that we show the simplest example and then point customers to the readme of @azure/identity for more details on the credential being used as well as examples of other credentials.

Any reason why we chose to list examples of all the credentials for the mixed-reality-remote-rendering package?

[v-xuto]

@MalcolmTyrrell Any ideas?

[v-xuto]

@MalcolmTyrrell Any ideas on this issue?

[MichaelZp0]

I think this issue was fixed with this pull request here #18648.

[MalcolmTyrrell]

@ramya-rao-a @v-xuto : Apologies for not seeing this earlier. My team switched away from this product.

The client contacts the Mixed Reality STS service via this SDK, to get authenticated for using the remote rendering service. This introduces a little subtlety into the different ways the client is constructed. In particular, if you provide an AccessToken the behavior is special (it bypasses the STS service). Is it true that we don't need to provide examples for every other credential type. I think I did that because I saw that another SDK did it :)

[ramya-rao-a]

Thanks for the clarification @MalcolmTyrrell!

The catch with providing examples for the different credential types is that we will always have newer credentials for newer scenarios and expecting each Azure SDK package to enumerate all would not be right.

So, in terms of credential usage, we would still recommend sticking to DefaultAzureCredential and then pointing to the @azure/identity readme for examples on other auth scenarios. We can keep the "Authenticating with a static access token" section as it does not use any credential types from @azure/identity

[v-xuto]

Close this issue, due to PR #18648 merged.