Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event-hubs] Move express sample to root /samples #14635

Closed
witemple-msft opened this issue Mar 31, 2021 · 1 comment
Closed

[event-hubs] Move express sample to root /samples #14635

witemple-msft opened this issue Mar 31, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Event Hubs

Comments

@witemple-msft
Copy link
Member

In #14074, I suggested relocating a potential storage sample that uses Azure Functions to /samples, reasoning being that only samples that explicitly deal with the package API should be included in the package's own samples directory.

We should consider doing the same for the expressSample in Event Hubs, since it's in basically the same situation of being an integration sample that lives within a specific package's repo.

If this becomes a pattern, then we probably will want to take some time to think about how to organize the root /samples folder to prevent it exploding.

CC @ramya-rao-a

@witemple-msft witemple-msft added EngSys This issue is impacting the engineering system. Event Hubs labels Mar 31, 2021
@witemple-msft witemple-msft added this to the [2021] May milestone Mar 31, 2021
@chradek chradek modified the milestones: [2021] May, [2021] June May 13, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jun 2, 2021
@chradek chradek modified the milestones: [2021] June, [2021] July Jun 10, 2021
@chradek chradek modified the milestones: [2021] July, [2021] August Jul 7, 2021
@kurtzeborn kurtzeborn added the Client This issue points to a problem in the data-plane of the library. label Oct 18, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] October, Backlog Oct 27, 2021
Copy link

Hi @witemple-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Event Hubs
Projects
None yet
Development

No branches or pull requests

5 participants