Closed
Description
openedon Mar 29, 2021
Richard Park started doing this in his PR. I'm aware that there's a circular dependency issue that I was able to spot due to storage-blob. This is about doing rush add -p @azure/identity@2.0.1--make-consistent
in one of the packages that depends on identity and to fix any issues that might arise.
There are some issues that we're aware of that need to be resolved per package:
tenantId
now can't be an invalidtenantId
, so use the recorder'sreplaceableVariables
to set one like12345678-1234-1234-1234-123456789012
.- Re-record the NodeJS tests, since MSAL does some more recordings (one of them being that they verify that the Identity endpoint is available, which is something our previous Identity client didn't do).
If you find any issues while upgrading, please report them in this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment