Skip to content

Fix ESlint errors for communication packages  #13723

Closed

Description

We have the linter enabled for all the communication packages, but are waiting to get all current linter errors fixed so that we can then enable the linter in CI to break the build on future regressions.

This issue is to ensure that we fix the these lint errors. Following are the steps to run ESLint for communication packages and reproduce this issue.

Set up your dev environment if not already done so as mentioned here

For each of the packages under <repo root>/sdk/communication other than arm-communication, do the following:

  • Go to the package folder in your terminal
  • Run rushx lint. This will generate an html report with name ending with lintReport.html in the same folder
  • Fix one or more of the linter errors in the html report, and send a PR!

Once all linter errors are fixed, update the lint script in the package.json file to remove the below so that any new linter errors would fail the CI

-f html -o <package name>-lintReport.html || exit 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

ClientThis issue points to a problem in the data-plane of the library.Communicationhelp wantedThis issue is tracking work for which community contributions would be welcomed and appreciated

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions