Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESLint errors for eventhub packages #10777

Closed
praveenkuttappan opened this issue Aug 23, 2020 · 1 comment · Fixed by #14677
Closed

Fix ESLint errors for eventhub packages #10777

praveenkuttappan opened this issue Aug 23, 2020 · 1 comment · Fixed by #14677
Assignees
@chradek
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Milestone
[2021] April

Comments

@praveenkuttappan
Copy link
Member

praveenkuttappan commented Aug 23, 2020 •
edited
Loading

Fix lint errors found in eventhub packages by ESLint. Following are the steps to run ESLint for eventhub packages and reproduce this issue.

  1. Set up your dev environment if not already done so as mentioned here
  2. Go to <repo root>/sdk/eventhub/<package-name>
  3. run rushx lint
  4. Command in step 2 generates an html report in directory <repo root>/sdk/eventhub/<package-name> with name ends with lintReport.html
  5. All lint errors found in this package is listed on html report.

Once all known issues are resolved, below change is required in package.json file in package root <repo root>/sdk/eventhub/<package-name> to treat any new lint regression as hard failure in CI.

  • Remove following snippet from lint command in package.json
    -f html -o template-lintReport.html || exit 0

Note: HTML report name prefix may be different for each package name to differentiate the report for each package.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 23, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Aug 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Aug 25, 2020
@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated and removed Up for grabs labels Sep 15, 2020
@deyaaeldeen deyaaeldeen mentioned this issue Sep 28, 2020
Closed
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, MQ-2020 Nov 16, 2020
@chradek chradek mentioned this issue Dec 23, 2020
Closed
@chradek chradek mentioned this issue Jan 19, 2021
Merged
ghost pushed a commit that referenced this issue Jan 21, 2021
@chradek
[event-hubs] fix eslint errors (round 1) (#13285)
379a18d 
Round 1 addressing #10777
Replaces #13013 

This leaves 5 errors and 15 warnings (excluding TSDoc) after this PR is merged.

- 4 'Promise executor functions should not be async' errors. Fixing this will take a lot of care and I would want these to be reviewed on their own so they don't get lost in the noise.
- 1 'N is already defined'. This is due to a constant matching an interface name.
ljian3377 pushed a commit to ljian3377/azure-sdk-for-js that referenced this issue Jan 22, 2021
@chradek @ljian3377
[event-hubs] fix eslint errors (round 1) (Azure#13285)
1f8d8ad 
Round 1 addressing Azure#10777
Replaces Azure#13013 

This leaves 5 errors and 15 warnings (excluding TSDoc) after this PR is merged.

- 4 'Promise executor functions should not be async' errors. Fixing this will take a lot of care and I would want these to be reviewed on their own so they don't get lost in the noise.
- 1 'N is already defined'. This is due to a constant matching an interface name.
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] March Feb 10, 2021
This was referenced Feb 11, 2021
Merged
Merged
ghost pushed a commit that referenced this issue Feb 11, 2021
@ramya-rao-a
[Event Hubs] Fix remaining TSDoc linting errors (#13746)
753b891 
This PR fixes the remaining TSDoc related linting errors in Event Hubs, thereby reducing the number of total linter problems from 70 to 38. Related to #12953 and #10777

@chradek Of the 38, errors are 18 and warnings are 20. Handing over the rest to your capable hands!
This was referenced Feb 22, 2021
Merged
Merged
@ramya-rao-a
Copy link
Contributor

The @azure/event-hubs package is fixed up.
The @azure/eventhubs-checkpointstore-blob is pending.
The @azure/event-processor-host will not be taken up as there is no active development there

ghost pushed a commit that referenced this issue Feb 22, 2021
@ramya-rao-a
[Event Hubs] Allow linter errs to break build (#13920)
745290d 
Fixes the last error in Event Hubs package and allows future linter errors to break the build.

We need to fix up the checkpoint store package before we can close the related issue #10777
@chradek chradek mentioned this issue Apr 2, 2021
Merged
@ghost ghost closed this as completed in #14677 Apr 2, 2021
ghost pushed a commit that referenced this issue Apr 2, 2021
@chradek
[eventhubs-checkpointstore-blob] fixes eslint errors (#14677)
f3520b9 
Resolves #10777 by addressing the last outstanding item.

With this change, `@azure/eventhubs-checkpointstore-blob` now no longer has eslint errors.
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
@chradek @vindicatesociety
[eventhubs-checkpointstore-blob] fixes eslint errors (Azure#14677)
f420ff8 
Resolves Azure#10777 by addressing the last outstanding item.

With this change, `@azure/eventhubs-checkpointstore-blob` now no longer has eslint errors.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
[2021] April
Development

Successfully merging a pull request may close this issue.

[eventhubs-checkpointstore-blob] fixes eslint errors chradek/azure-sdk-for-js
3 participants
@ramya-rao-a @chradek @praveenkuttappan