feedback by Jeremy

Azure · Jun 25, 2021 · b561d19 · b561d19
1 parent fdd9ecf
commit b561d19
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/sdk/core/core-http/src/policies/throttlingRetryPolicy.ts b/sdk/core/core-http/src/policies/throttlingRetryPolicy.ts
@@ -50,16 +50,15 @@ export class ThrottlingRetryPolicy extends BaseRequestPolicy {
   }
 
   public async sendRequest(httpRequest: WebResourceLike): Promise<HttpOperationResponse> {
-    return this._nextPolicy.sendRequest(httpRequest.clone()).then((response) => {
-      if (
-        response.status !== StatusCodes.TooManyRequests &&
-        response.status !== StatusCodes.ServiceUnavailable
-      ) {
-        return response;
-      } else {
-        return this._handleResponse(httpRequest, response);
-      }
-    });
+    const response = await this._nextPolicy.sendRequest(httpRequest.clone());
+    if (
+      response.status !== StatusCodes.TooManyRequests &&
+      response.status !== StatusCodes.ServiceUnavailable
+    ) {
+      return response;
+    } else {
+      return this._handleResponse(httpRequest, response);
+    }
   }
 
   private async _defaultResponseHandler(

diff --git a/sdk/identity/identity/test/internal/node/managedIdentityCredential.spec.ts b/sdk/identity/identity/test/internal/node/managedIdentityCredential.spec.ts
@@ -248,8 +248,6 @@ describe("ManagedIdentityCredential", function() {
   });
 
   it("IMDS MSI retries also retries on 503s", async function() {
-    process.env.AZURE_CLIENT_ID = "errclient";
-
     const mockHttpClient = new MockAuthHttpClient({
       // First response says the IMDS endpoint is available.
       authResponse: [
@@ -274,7 +272,7 @@ describe("ManagedIdentityCredential", function() {
     });
 
     const credential = new ManagedIdentityCredential(
-      process.env.AZURE_CLIENT_ID,
+      "errclient",
       mockHttpClient.tokenCredentialOptions
     );