-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KeyVault] - Update duration sample and doc comments (#18508)
## What - Use Day.js in the Key Rotation sample - Update the doc comments for Key Rotation ## Why We discussed adding updating the API of Key Rotation to take an object instead of a raw string for ISO8601 durations; however, with Temporal adding support for Durations we want to avoid duplicating the type for now. Instead, we decided to demonstrate interop with an existing 3rd party library. I chose Day.js for this sample as it has a nice clean API.
- Loading branch information
Showing
4 changed files
with
20 additions
and
3 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters