Skip to content

Commit

Permalink
Remove Node v8 from run matrix (#15647)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremymeng committed Jun 9, 2021
1 parent 66c6025 commit 072f7ab
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
12 changes: 0 additions & 12 deletions eng/pipelines/templates/jobs/smoke.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ jobs:
condition: and(succeeded(), eq(dependencies.smoke_test_eligibility.outputs['check_smoke_tests.RunSmokeTests'], true))
strategy:
matrix:
Linux Node8 (AzureCloud):
Pool: Azure Pipelines
OSVmImage: "macOS-10.14"
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
ArmTemplateParameters: $(AzureCloudArmTemplateParameters)
NodeTestVersion: "8.x"
Mac Node10 (AzureCloud):
Pool: Azure Pipelines
OSVmImage: "macOS-10.14"
Expand Down Expand Up @@ -192,15 +186,9 @@ jobs:
displayName: List packages installed from the feed

- script: npm run smoke-test -- --devops-logging
condition: and(succeeded(), ne(variables.NodeTestVersion, '8.x'))
workingDirectory: common/smoke-test/
displayName: Run smoke tests

- script: npm run smoke-test-node8 -- --devops-logging
condition: and(succeeded(), eq(variables.NodeTestVersion, '8.x'))
workingDirectory: common/smoke-test/
displayName: Run smoke tests (Node 8)

- template: /eng/common/TestResources/remove-test-resources.yml
parameters:
SubscriptionConfiguration: $(SubscriptionConfiguration)
2 changes: 1 addition & 1 deletion eng/pipelines/templates/stages/platform-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" },
"macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" }
},
"NodeTestVersion": [ "8.x", "10.x", "12.x", "14.x", "16.x" ],
"NodeTestVersion": [ "10.x", "12.x", "14.x", "16.x" ],
"TestType": "node",
"TestResultsFiles": "**/test-results.xml"
},
Expand Down

0 comments on commit 072f7ab

Please sign in to comment.