Skip to content

Fix incorrect handling in Remove-Azure-Artifacts-From-Cache.ps1 script #47714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 1 commit into from
Jan 14, 2026
Merged

Fix incorrect handling in Remove-Azure-Artifacts-From-Cache.ps1 script #47714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions eng/scripts/Remove-Azure-Artifacts-From-Cache.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ foreach ($rootFolder in $rootFolders) {
# For each artifact root folder try to find maven-metadata-central.xml as that will determine which versions
# of the artifact to retain in the DevOps cache.
$mavenMetadataCentralPath = Join-Path -Path $artifactRootFolder -ChildPath "maven-metadata-central.xml"
$mavenCentralVersions = {}
$mavenCentralVersions = @()
if (Test-Path -Path $mavenMetadataCentralPath) {
# Folder contains a 'maven-metadata-central.xml' file, parse it to determine which subfolders should be deleted.
#
Expand All @@ -47,7 +47,7 @@ foreach ($rootFolder in $rootFolders) {
# folders which is constant with the previous design where the root folders were indiscriminately cleaned, best case
# this only deletes built from source folders.
$metadataXml = [XML](Get-Content $mavenMetadataCentralPath)
$mavenCentralVersions = Select-Xml -Xml $metadataXml -XPath "/metadata/versioning/versions/version" | ForEach-Object {$_.Node.InnerXml}
$mavenCentralVersions = @(Select-Xml -Xml $metadataXml -XPath "/metadata/versioning/versions/version" | ForEach-Object {$_.Node.InnerXml})
} else {
# Folder doesn't contain a 'maven-metadata-central.xml' file, delete the entire folder as it cannot be determined
# what was built from source vs resolved from Maven central.
Expand All @@ -57,21 +57,22 @@ foreach ($rootFolder in $rootFolders) {
}

$mavenMetadataLocalPath = Join-Path -Path $artifactRootFolder -ChildPath "maven-metadata-local.xml"
$mavenLocalVersions = {}
$mavenLocalVersions = @()
if (Test-Path -Path $mavenMetadataLocalPath) {
# Folder contains a 'maven-metadata-local.xml' file, parse it to determine which subfolders should be deleted.
#
# For example the metadata file lists azure-core 1.33.0 and 1.34.0-beta.1 and there are folders 1.33.0 and 1.34.0-beta.1
# all folders will be deleted as Maven built those versions locally. Worst case, this over deletes folders which is constant
# with the previous design where the root folders were indiscriminately cleaned, best case this only deletes built from source folders.
$metadataXml = [XML](Get-Content $mavenMetadataLocalPath)
$mavenLocalVersions = Select-Xml -Xml $metadataXml -XPath "/metadata/versioning/versions/version" | ForEach-Object {$_.Node.InnerXml}
$mavenLocalVersions = @(Select-Xml -Xml $metadataXml -XPath "/metadata/versioning/versions/version" | ForEach-Object {$_.Node.InnerXml})

# Additionally, since we know the file exists, delete it. We don't want to cache information about what packages were built
# locally as this could change build-to-build. For example, in one job 1.30.0 could be built locally while releasing, but
# in the next job 1.31.0-beta.1 could be built locally as the version incremented. We don't want the file to then state both
# 1.30.0 and 1.31.0-beta.1 were built locally.
Write-Host "Deleting maven-metadata-local.xml '$mavenMetadataLocalPath'."
Remove-Item $mavenMetadataLocalPath -ErrorAction Ignore
}

# Now loop over each directory in this package. These directories should be the versions built locally or resolved from
Expand Down