Skip to content

Add new property session idle timeout for service bus session processor client #44630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2025
Merged

Add new property session idle timeout for service bus session processor client #44630

merged 5 commits into from
Mar 18, 2025

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Mar 13, 2025 •
edited
Loading

Description

Fixes #44414, only add a new propertysessionIdleTimeout for the service bus session processor client.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Mar 13, 2025
@moarychan moarychan mentioned this pull request Mar 13, 2025
Closed
@moarychan moarychan marked this pull request as ready for review March 13, 2025 06:38
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 13, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.spring:spring-messaging-azure-servicebus
com.azure.spring:spring-cloud-azure-autoconfigure
com.azure.spring:spring-cloud-azure-service

rujche
rujche approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rujche
rujche approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@moarychan moarychan merged commit 916bed5 into Azure:main Mar 18, 2025
26 checks passed
Netyyyy pushed a commit that referenced this pull request Mar 19, 2025
@moarychan @Netyyyy
Add new property session idle timeout for service bus session process…
3912a25 
…or client (#44630)

(cherry picked from commit 916bed5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@rujche rujche rujche approved these changes

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Peek-Lock mode on sessionful subscriptions with custom session idle timeout
4 participants
@moarychan @azure-sdk @saragluna @rujche