Skip to content

Support parsing AAD Audience from connection string#44482

Merged
harsimar merged 4 commits intomainfrom
harskaur/aadAudience
Mar 14, 2025
Merged

Support parsing AAD Audience from connection string#44482
harsimar merged 4 commits intomainfrom
harskaur/aadAudience

Conversation

@harsimar
Copy link
Member

@harsimar harsimar commented Mar 4, 2025

Description

This PR adds support for parsing the AAD Audience from the connection string. If there isn't an audience provided, it will use the default audience and scope (https://monitor.azure.com//.default). This is so we can support AAD auth in sovereign clouds. The AzureMonitorExporterBuilder will call ConnectionString.getAadAudienceWithScope() so that the correct scope is used in http pipeline policies.

This has been tested in the sovereign cloud environment.
Note that for autoconfigure, quickpulse & profiler are not supported so only telemetry flow to Breeze was tested here.

There will a PR added in ApplicationInsights-Java repo so that the java agent can also utilize this functionality. With that draft PR, flow to quickpulse & breeze has been confirmed in sovereign clouds.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Mar 4, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-monitor-opentelemetry-autoconfigure

@harsimar harsimar marked this pull request as ready for review March 13, 2025 20:56
Copy link

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimar harsimar merged commit d5c603b into main Mar 14, 2025
51 checks passed
@harsimar harsimar deleted the harskaur/aadAudience branch March 14, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OpenTelemetry OpenTelemetry instrumentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants