Support parsing AAD Audience from connection string#44482
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
3 tasks
jeanbisutti
reviewed
Mar 14, 2025
...onitor/opentelemetry/autoconfigure/implementation/configuration/ConnectionStringBuilder.java
Show resolved
Hide resolved
jeanbisutti
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing the AAD Audience from the connection string. If there isn't an audience provided, it will use the default audience and scope (https://monitor.azure.com//.default). This is so we can support AAD auth in sovereign clouds. The AzureMonitorExporterBuilder will call ConnectionString.getAadAudienceWithScope() so that the correct scope is used in http pipeline policies.
This has been tested in the sovereign cloud environment.
Note that for autoconfigure, quickpulse & profiler are not supported so only telemetry flow to Breeze was tested here.
There will a PR added in ApplicationInsights-Java repo so that the java agent can also utilize this functionality. With that draft PR, flow to quickpulse & breeze has been confirmed in sovereign clouds.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines