Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pong frames #43968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pong frames #43968

wants to merge 1 commit into from

Conversation

jjoslin
Copy link

@jjoslin jjoslin commented Jan 28, 2025

Description

Per the WebSocket spec[1] the pong should contain the contents of the ping. Without this change the OpenAI server drops the connection shortly after the first ping is sent.

[1] https://datatracker.ietf.org/doc/html/rfc6455#section-5.5.3

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jjoslin
Fix pong frames
af6cefe 
Per the WebSocket spec[1] the pong should contain the contents of the ping. Without this change the OpenAI server drops the connection shortly after the first ping is sent.

[1] https://datatracker.ietf.org/doc/html/rfc6455#section-5.5.3
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI labels Jan 28, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution @jjoslin! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandom-msft brandom-msft Awaiting requested review from brandom-msft brandom-msft is a code owner

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoslin @azure-sdk