Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation-processor to clientcore ci.yml #43886

Merged
merged 21 commits into from
Jan 28, 2025

Conversation

samvaity
Copy link
Member

@samvaity samvaity commented Jan 22, 2025

Description

This PR

  • adds annotation-processor tooling to clientcore:parent pom so anything that has clientcore:parent inherits that compiler configuration.
  • Updated the strategy to not have the annotation processor in parent pom and let each client library add the plugin to their respective poms, to avoid creating circular dependencies between annotation processors and the clientcore libraries
  • adds a annotation-processor-dependency-test module for testing the annotation-processor service client impl generation. It simulates the structure of client library adding annotation-processor compiler configuration and clientcore:core dependency
  • adds annotation-processor to ci.yml to enable releases
  • remove clientcore:tools module

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@samvaity samvaity force-pushed the add-annotation-processor branch from dca7c04 to 243377a Compare January 23, 2025 18:12
@samvaity samvaity self-assigned this Jan 23, 2025
@samvaity samvaity marked this pull request as ready for review January 23, 2025 18:17
@samvaity samvaity force-pushed the add-annotation-processor branch from 9159d00 to 045da49 Compare January 23, 2025 19:50
@samvaity samvaity force-pushed the add-annotation-processor branch 2 times, most recently from 855d4f7 to 63baffc Compare January 23, 2025 20:05
@samvaity samvaity force-pushed the add-annotation-processor branch from 43dd382 to 371b10c Compare January 27, 2025 08:27
@samvaity samvaity force-pushed the add-annotation-processor branch from 371b10c to 0e1aa85 Compare January 27, 2025 22:39
@samvaity samvaity changed the title Add annotation-processor to clientcore parent maven configuration Add annotation-processor to clientcore ci.yml Jan 27, 2025
@samvaity samvaity force-pushed the add-annotation-processor branch 3 times, most recently from de73f3c to fff7e8e Compare January 28, 2025 01:26
@samvaity samvaity force-pushed the add-annotation-processor branch from fff7e8e to 9e2b773 Compare January 28, 2025 01:49
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

io.clientcore:annotation-processor

@samvaity samvaity merged commit e695902 into Azure:main Jan 28, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants