-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation-processor to clientcore ci.yml #43886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvaity
commented
Jan 22, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/TestInterfaceClientService.java
Outdated
Show resolved
Hide resolved
samvaity
commented
Jan 22, 2025
sdk/clientcore/core/src/main/java/io/clientcore/core/TestInterfaceServiceVersion.java
Outdated
Show resolved
Hide resolved
dca7c04
to
243377a
Compare
samvaity
commented
Jan 23, 2025
...rocessor/src/main/java/io/clientcore/tools/codegen/templating/JavaPoetTemplateProcessor.java
Show resolved
Hide resolved
srnagar
reviewed
Jan 23, 2025
...n-processor-dependency-tests/src/main/java/io/clientcore/tools/codegen/MockHttpResponse.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/tools/annotation-processor-dependency-tests/pom.xml
Outdated
Show resolved
Hide resolved
sdk/clientcore/tools/annotation-processor-dependency-tests/README.md
Outdated
Show resolved
Hide resolved
9159d00
to
045da49
Compare
855d4f7
to
63baffc
Compare
srnagar
approved these changes
Jan 23, 2025
...-processor-tests/src/main/java/io/clientcore/annotation/processor/test/MockHttpResponse.java
Outdated
Show resolved
Hide resolved
...core/annotation-processor/src/main/java/io/clientcore/tools/codegen/AnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...on-processor/src/main/java/io/clientcore/tools/codegen/utils/ResponseBodyModeGeneration.java
Outdated
Show resolved
Hide resolved
43dd382
to
371b10c
Compare
371b10c
to
0e1aa85
Compare
de73f3c
to
fff7e8e
Compare
fff7e8e
to
9e2b773
Compare
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
adds annotation-processor tooling to clientcore:parent pom so anything that has clientcore:parent inherits that compiler configuration.annotation-processor-dependency-test
module for testing the annotation-processor service client impl generation. It simulates the structure of client library adding annotation-processor compiler configuration and clientcore:core dependencyclientcore:tools
moduleAll SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines